JWally / jsLPSolver

Simple OOP javaScript library to solve linear programs, and mixed integer linear programs
The Unlicense
420 stars 69 forks source link

Fixed crash when MILP problem is unfeasible #28

Closed bchevalier closed 8 years ago

bchevalier commented 8 years ago

Done by making sure testing whether a bestBranch has been initialised. If not, the problem is unfeasible.

Also optimised the solution object returned by the MILP by making a proper class structure called MilpSolution.

JWally commented 8 years ago

Merged

bchevalier commented 8 years ago

Yo Justin,

It actually looks like this hasn't been merged! Can I merge it?

JWally commented 8 years ago

I got it. Sorry about that!

bchevalier commented 8 years ago

thanks!

admin4life commented 8 years ago

Guys thank you so much for the work you have done on this. This library is so amazing and SO FAST! Wow I was just wondering if you could push the newest version containing this merge to NPM. BIG THANKS!

JWally commented 8 years ago

Big thanks! Credit goes to Brice! I'll bump the version up tonight (CST) and push to NPM.

Thanks! -JWW

On Thu, Feb 11, 2016 at 9:29 AM, Ian H notifications@github.com wrote:

Guys thank you so much for the work you have done on this. This library is so amazing and SO FAST! Wow I was just wondering if you could push the newest version containing this merge to NPM. BIG THANKS!

— Reply to this email directly or view it on GitHub https://github.com/JWally/jsLPSolver/pull/28#issuecomment-182917137.

bchevalier commented 8 years ago

@admin4life thanks for the feedback. Do not hesitate to let us know of any bug you might encounter or any improvement you would like to have (more functionalities or more speed).