search

JYU-IBA / potku

Potku is analysis and simulation software for ToF-ERD measurements
https://www.jyu.fi/science/en/physics/research/infrastructures/accelerator-laboratory/pelletron/potku/
GNU General Public License v2.0
7 stars 7 forks source link

Update submodule JIBAL #283

Closed samivout closed 3 months ago

samivout commented 1 year ago

Update Potku's submodule JIBAL to its newest version and add support for it in Potku.

samivout commented 1 year ago

This is functional at least on Windows. Linux and Mac functionality should still be tested, as the commandline argument order for jibaltool might be different for the other operating systems.

jaakkojulin commented 1 year ago

The implemented order of command line arguments should work on Linux and MacOS. Testing is still strongly encouraged.

It might also make sense to check that the return value of running jibaltool (Popen.returncode? or subprocess.run(..., check=True) is zero (success) or use some other check to see that jibaltool runs correctly, unless the output parsing already handles this, in which case feel free to ignore this suggestion.