JYU-IBA / potku

Potku is analysis and simulation software for ToF-ERD measurements
https://www.jyu.fi/science/en/physics/research/infrastructures/accelerator-laboratory/pelletron/potku/
GNU General Public License v2.0
7 stars 7 forks source link

Fix makefile and packaging issues #312

Closed samivout closed 1 year ago

samivout commented 1 year ago

I noticed some issues with the compilation of the C apps (tof_list and erd_depth specifically) in the automatic packaging process. In the logs there were errors about undefined references and not finding header files. On Linux there was problems with linking math.h and on macOS there was an issue about finding gsto_masses.h.

I fixed these issues in the makefiles by setting the compiler argument -lm as the last one and fixing a bad indentation in the depend rule, which is used to link the dependencies.

Additionally PyInstaller version isn't pinned anywhere and it recently updated to version 6.0.0, which caused some packaging issues. I pinned the PyInstaller version in package_potku.yaml file to 5.13.2 and also wrote it in the README.md.

Finally I added a README_macOS.txt to be bundled in the macOS distribution to get users to run $ xattr -r -d com.apple.quarantine . before running Potku.