Jacks0nJ / PyFPT

Stochastic first-passage time (FPT) simulations using importance sampling.
Apache License 2.0
11 stars 1 forks source link

[JOSS Review] Comments on User Guide 3 notebook #45

Open CFGrote opened 2 years ago

CFGrote commented 2 years ago

Re https://github.com/openjournals/joss-reviews/issues/4607

This is a very nice notebook as it clearly demonstrates PyFPT's limitations and points to ways how to overcome these. I found parts of it a bit hard to understand and a number of typos, as listed below.

I don't make a pull request as merging notebooks can be nasty.

Jacks0nJ commented 2 years ago

Hi @CFGrote, Thanks for spotting the typos. I'll update the guide soon to implement your recommendations :).

Will let you know when this is done.

Jacks0nJ commented 2 years ago

Hi @CFGrote, I've fixed almost all of the typos you've spotted. But there were a few where I've done things slightly different to how you recommended.

Do let me know if you spot anything else! And cheers again!