Open CFGrote opened 2 years ago
Hi @CFGrote, Thanks for spotting the typos. I'll update the guide soon to implement your recommendations :).
Will let you know when this is done.
Hi @CFGrote, I've fixed almost all of the typos you've spotted. But there were a few where I've done things slightly different to how you recommended.
Where I referred to using Mathematica, I've simply cited the paper where this is method is detailed instead. For people interested in using PyFPT this particular case is only of interesting for benchmarking the method, and this was done in the paper.
For your correction for "editing", the only time I can see I use this word is "manually editing PyFPT", which I don't think should include a "the". But of course let me know if you disagree or I missed the sentence you were referring to.
Do let me know if you spot anything else! And cheers again!
Re https://github.com/openjournals/joss-reviews/issues/4607
This is a very nice notebook as it clearly demonstrates PyFPT's limitations and points to ways how to overcome these. I found parts of it a bit hard to understand and a number of typos, as listed below.
I don't make a pull request as merging notebooks can be nasty.