Jacobs63 / vue3-tabs-component

Vue 3 tabs component
MIT License
96 stars 27 forks source link

valid ES Module #11

Closed lperez22 closed 2 years ago

lperez22 commented 2 years ago

Hello we are currently using this package with Nuxt3 and now all packages are required to be valid ES Modules, this package does work in our project however we get the following warning and wanted to know if this package could be corrected

vue3-tabs-component doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.

Jacobs63 commented 2 years ago

Greetings,

unpkg & module were defined in 1.0.11, which should help with this issue.

However, I was unable to reproduce this on a fresh Nuxt3 installation beforehand either, so if you could add some steps to reproduce I'd appreciate it.

lperez22 commented 2 years ago

At the time we were on version 1.0.5, running nuxi build produced this message image but with the latest version of this package I no longer get the warning so no longer an issue.

Jacobs63 commented 2 years ago

Thank you for the clarification, so it should be fixed now.