JagandeepBrar / lunasea

Self-hosted software controller built using Flutter
https://www.lunasea.app
GNU General Public License v3.0
1.28k stars 63 forks source link

[Bug] Webhook notifications do not work on devices without Google Play Services #470

Closed ethanmlee closed 2 years ago

ethanmlee commented 3 years ago

Describe the Bug webhook not copying to clipboard on android device (android 10) when tapping the device button on any of the services present on the Notification settings page

To Reproduce Open LunaSea v5.0.0 (50000019) on android 10 device go to Settings > Notifications > tap "device" under Lidarr, Overseerr, Radarr, Sonarr, or Tuatulli.

Expected Behaviour the webhook url to be copied to the clipboard when tapping device

Versions LunaSea v5.0.0 (50000019)

JagandeepBrar commented 3 years ago

Can you let me know which device you are using?

I am running Android 11 on a Pixel 3, have no issues copying the webhook URLs.

shammyfiveducks commented 3 years ago

Same issue for V5.1- Webhooks URL will not copy to clipboard.

I have a Huawei P40 phone - is it something to do with the lack of Google Services maybe?

ethanmlee commented 3 years ago

Same issue for V5.1- Webhooks URL will not copy to clipboard.

I have a Huawei P40 phone - is it something to do with the lack of Google Services maybe?

i didn't think about google play services. I have a oneplus 5t running crdroid with microg. that is probably what the issue is tbqh.

JagandeepBrar commented 3 years ago

Same issue for V5.1- Webhooks URL will not copy to clipboard.

I have a Huawei P40 phone - is it something to do with the lack of Google Services maybe?

Ah, yes. LunaSea's notification backend relies on Firebase, which in turn relies on Google Services. I will add checks within LunaSea to hide the notification section for users without Firebase support, but for the time being notifications (and any user account features) will not be compatible with devices without Google Services.