search

JakeWharton / u2020

A sample Android app which showcases advanced usage of Dagger among other open source libraries.
https://www.youtube.com/watch?v=0XHx9jtxIxU
Apache License 2.0
5.68k stars 930 forks source link

Use ShareCompat to have the perfect sharing experience. #188

Closed tasomaniac closed 9 years ago

tasomaniac commented 9 years ago

ShareCompat is used to always have good sharing Intent with necessary flags attached to it.

Here is the screenshots from old and new versions. In the old version you can see that Google Inbox app seems to be inside the screen of U+202 Internal.

Old New
screenshot_2015-08-14-09-51-39 screenshot_2015-08-14-09-50-30
JakeWharton commented 9 years ago

LGTM. I'll let @mattprecious look since this is all his code.

mattprecious commented 9 years ago

Awesome! Did not know this existed.

tasomaniac commented 9 years ago

Thank you @JakeWharton and @mattprecious for reviewing and merging it.

I learn a lot from this codebase. It is good to give something back even if it is really little.

mattprecious commented 9 years ago

FYI: http://b.android.com/184179

Doesn't affect u2020, but might revert this change anyway so this doesn't get copied into apps that have 3+ attachments.

tasomaniac commented 9 years ago

The thing I fixed was to use the new task flag when creating the intent. ShareCompat adds that flag while creating it.

If the bug is a concern we can revert this and just add the flag to the old code.

On Fri, Sep 4, 2015, 11:34 PM Matthew Precious notifications@github.com wrote:

FYI: https://b.android.com/184179

Doesn't affect u2020, but might revert this change anyway so this doesn't get copied into apps that have 3+ attachments.

— Reply to this email directly or view it on GitHub https://github.com/JakeWharton/u2020/pull/188#issuecomment-137846303.