search

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
647 stars 62 forks source link

PHP 7.4: fix deprecation notice #143

Closed jrfnl closed 4 years ago

jrfnl commented 5 years ago

PHP 7.4 deprecates the use of curly braces for array/string character access.

See: https://wiki.php.net/rfc/deprecate_curly_braces_array_access

jrfnl commented 5 years ago

@JakubOnderka Anything I can do to move this PR (and the others I opened) forward ?

jrfnl commented 5 years ago

@JakubOnderka Bumping again... I know the build on this PR doesn't pass, but in combination with my other PRs the build will start passing again.

Could this (and my other PRs) please get some attention ?

The tool not being compatible with PHP 7.4 is a blocker to start using it for a number of projects I'm involved with.

nicwortel commented 4 years ago

This will solve #154.

@JakubOnderka merging (and releasing) this PR would be greatly appreciated!

szepeviktor commented 4 years ago

@JakubOnderka Could you help this PR to be merged?

szepeviktor commented 4 years ago

@jrfnl What would you say if I fork this and merge all PR-s, resolve all issues there?

jrfnl commented 4 years ago

@szepeviktor I already have (to confirm that the combined PRs fix all build issues) : https://github.com/jrfnl/PHP-Parallel-Lint/tree/test/all-together-now

szepeviktor commented 4 years ago

I see https://github.com/jrfnl/PHP-Parallel-Lint/commits/test/all-together-now

How about publishing and maintaining it?

jrfnl commented 4 years ago

@szepeviktor If @JakubOnderka is abandoning this project and would confirm this, I'd definitely consider it. Otherwise, I think it be better for this canonical to be updated instead.

szepeviktor commented 4 years ago

Ci fixed in https://github.com/JakubOnderka/PHP-Parallel-Lint/pull/155

ramondelafuente commented 4 years ago

I've switched to @jrfnl's branch for now, but I agree that maintenance should not move implicitly.

@JakubOnderka You've done great work with this, and it's perfectly fine not to jump at every ticket. But it looks like the PR's that have been opened are valid. Do you intend to merge and keep maintaining this package?

grogy commented 4 years ago

Hi,

I am using your PR for solve problems. Because author of this great tool does not communicate so I created fork. You can use it from packagist. Now is out new release with PHP 7.4 support.

Krinkle commented 4 years ago

The fork from @grogy has been officially recognised and continues under a new GitHub organisation at https://github.com/php-parallel-lint/PHP-Parallel-Lint.

This move is recognised in the project's readme (commit).

Thank you @JakubOnderka! 🎉

jrfnl commented 4 years ago

@Krinkle Great news, though it would be even nicer if PRs opened there would start getting merged... 10 open PRs and counting. 8 which are over 3 weeks old by now. :heart_eyes:

/cc @grogy

jrfnl commented 4 years ago

Closing as this has been merged in the new repo: https://github.com/php-parallel-lint/PHP-Parallel-Lint