search

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
647 stars 62 forks source link

Fix linting on Windows #66

Closed mdio closed 8 years ago

mdio commented 8 years ago

The changes from 0.9.1 in src/Process/SkipLintProcess.php to supply the content of bin/skip-linting.php to the command line via -r broke linting on Windows.

Apparently double quotes are not escaped correctly by escapeshellarg on Windows.

I also added an appveyor.yml for further automatic testing on Windows (as a starting point). See build results before and after.

mdio commented 8 years ago

If you want to include parallel-lint to appveyor.yml, use php parallel-lint.php to start it. Works for me at least.

JakubOnderka commented 8 years ago

Cool, I do not know appveyor service. Look great :+1:

And thanks, I do not use Windows for six years :) But I am wondered why 'vendor\bin\tester' on Windows works,

mdio commented 8 years ago

It works because it has a tester.bat (.cmd would work as well) that calls PHP with the tester.php bootstrap file.

To clarify: If you have an executable (.exe but also .bat or .cmd) then you can omit the extension when calling it. It looks like the calls are the same on Windows and Linux but Linux uses tester and Windows uses tester.bat.