search

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
647 stars 62 forks source link

add option --color #78

Closed glensc closed 7 years ago

glensc commented 8 years ago

there exists --no-color option, but no opposite option --color.

the colorfulness seems to be auto detected, and the detection algorithm is unknown and it's apparently failing in ci environments where no real tty exists. would be nice to to force colors there.

grogy commented 8 years ago

It is great candidate for #Hacktoberfest.

@JakubOnderka you add label "Hacktoberfest", please?

glady commented 8 years ago

Nothing to do here for enabling colors. Colors are enabled by default and color-classes are set to force style. The problem seems to be within other project JakubOnderka/PHP-Console-Color within function \JakubOnderka\PhpConsoleColor\ConsoleColor::styleSequence. I made a pull request there (https://github.com/JakubOnderka/PHP-Console-Color/pull/10).

But here are more problems with that change. There is now really no further autodetection. On really not supported systems now the default creates a colored output. I will try to adapt that issue tomorrow and force styles on ConsoleColor, only if --color is given.

glady commented 8 years ago

I should test first, before writing comments. I think the pull request #82 fixes this problem without changing ConsoleColor. I think there is no error, so i closed that other change.

JakubOnderka commented 7 years ago

Pull request #82 merged into master