Jaliborc / Bagnon

Single window displays for you items
200 stars 112 forks source link

bagnon not working since war whitin did a prepatch #1911

Open Shockangel opened 3 months ago

Shockangel commented 3 months ago

Which software were you running? bagnon curse forge

Have you read the changelog? yes

Please describe the bug. bagnon is not working since tww patch nothing happens when click on it or use the b button had to take add on off just to access my bags please please fix it its crazy world of warcraft now

nvrsbr commented 3 months ago

Why no TWW version yet?

AmazingSpanoMan commented 3 months ago

Why do TWW version yet?

Not sure what this means...

Anyway. Yes I can confirm TWW pre-patch has broken this addon.

LorenzoRogai commented 3 months ago

see here https://github.com/Jaliborc/Bagnon/issues/1909#issuecomment-2251163972

Dadderz commented 3 months ago

It seems that when you activate Bagbrother, the primary piece required to run bagnon, the addon fails to work. Pressing the "B" key does nothing. Bug grabber goes off about the addon. I reactivated the addon with its comments and this is the first error captured. There were a total of 18 addon crashes. 6x ...aceBagBrother/libs/Poncho-2.0-3/Poncho-2.0.lua:183: attempt to index a nil value [string "@BagBrother/libs/Poncho-2.0-3/Poncho-2.0.lua"]:183: in main chunk

Locals: Lib =

{ SuperCall =
{ } ClassMeta =
{ } Base =
{ } } Base =
{ __type = "Abstract" } ClassMeta =
{ }

Here is the third error in the list

6x .../BagBrother/libs/Sushi-3.2-1/classes/core/Callable.lua:20: attempt to index field 'Base' (a nil value) [string "@BagBrother/libs/Sushi-3.2-1/classes/core/Callable.lua"]:20: in main chunk

Locals: (temporary) = nil (temporary) = nil (temporary) = "Sushi-3.2" (temporary) = nil (*temporary) = "attempt to index field 'Base' (a nil value)"

This is the 4th error

5x ...ns/BagBrother/libs/Sushi-3.2-1/classes/core/Tipped.lua:20: attempt to index field 'Callable' (a nil value) [string "@BagBrother/libs/Sushi-3.2-1/classes/core/Tipped.lua"]:20: in main chunk

Locals: (temporary) = nil (temporary) = nil (temporary) = "Sushi-3.2" (temporary) = nil (*temporary) = "attempt to index field 'Callable' (a nil value)"

There are others....

Dadderz commented 3 months ago

In addition, when loading Bagnon Scrap, the addon throws errors

2x ...crap/libs/Sushi-3.2-1/classes/buttons/ExpandHeader.lua:1: attempt to index field 'Clickable' (a nil value) [string "@Scrap/libs/Sushi-3.2-1/classes/buttons/ExpandHeader.lua"]:1: in main chunk

Locals: (temporary) = nil (temporary) = nil (temporary) = "Sushi-3.2" (temporary) = nil (temporary) =

{ } (temporary) = 1 (*temporary) = "attempt to index field 'Clickable' (a nil value)"

stingray66 commented 3 months ago

Bag Brother is a dependancy of Bagnon and Bagnon will not work without it..this is the error message i get when i try to open bags.

Message: ...ace/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:183: attempt to index a nil value Time: Thu Jul 25 15:29:20 2024 Count: 1 Stack: ...ace/AddOns/BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:183: attempt to index a nil value

Locals: i temporarily to fixed mine to get bags to open..go to World of Warcraftretail\Interface\AddOns\BagBrother\libs\Poncho-2.0.lua ..open Poncho 2.0.lua with notepad++ and go down to line 183 and put -- in front of that line...the bags opened as they should...i know it's not a perma fix but it worked for me hope it works for you

koaschten commented 3 months ago

@stingray66 may I suggest to not suggest just disabling functions by adding -- in front of them, but replacing the faulty function calls with working ones as suggested in the other thread here: https://github.com/Jaliborc/Bagnon/issues/1909#issuecomment-2251142019

Cmed1967 commented 3 months ago

Adding to this as well! When will it be updated? It's completely broken at this point, unusable! So are all the extras people ate making for this add-on. Please make the time to restore this wonderful add-on!!

Venomstick commented 3 months ago

I couldn't find Bag Brother on CurseForge. But I will say I HATE not having Bagnon working. PLEASE someone make them fix it :[

jamesw71 commented 3 months ago

Bagnon isn't working when bagbrother is enabled...was able to disable bagbrother and bagnon worked for my bags, but not for my bank.

HolgerDKz commented 3 months ago

Bagnon isn't working when bagbrother is enabled...was able to disable bagbrother and bagnon worked for my bags, but not for my bank.

Take a look at Aur0r4s comment above from another issue thread.

Venomstick commented 3 months ago

Thank you!

On Thu, Aug 1, 2024, 02:30 HolgerDKz @.***> wrote:

Bagnon isn't working when bagbrother is enabled...was able to disable bagbrother and bagnon worked for my bags, but not for my bank.

Take a look at Aur0r4s comment above from another issue thread.

— Reply to this email directly, view it on GitHub https://github.com/Jaliborc/Bagnon/issues/1911#issuecomment-2262155043, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKGI64TI5TPQ5ZMVE7LLZELZPHIWXAVCNFSM6AAAAABLPPTFX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRSGE2TKMBUGM . You are receiving this because you were mentioned.Message ID: @.***>

dkrusky commented 3 months ago

Bagnon-11.0.2.zip

Here is an updated version of Bagnon with various patches from here after determining which code changes resulted in either a direct patch, or came very close but required more skill to patch.

Also replaced dialog hook to close bank window, with the new secure call.

Voxxel commented 3 months ago

Bagnon-11.0.2.zip

Here is an updated version of Bagnon with

Thank you. With warbank support ?

jaumebp commented 3 months ago

When i click the warbank spell i'm sent to my personal bank. In any case, thanks whoever fixed it!

dkrusky commented 3 months ago

Bagnon-11.0.2.zip

Here is an updated version of Bagnon with

Thank you. With warbank support ?

No full warbank support. Just needed to get it working properly so it was usable again for the features that exist

dkrusky commented 3 months ago

When i click the warbank spell i'm sent to my personal bank. In any case, thanks whoever fixed it!

You are very welcome. Enjoy. Hopefully this author shows up sometime soon :)

jamesw71 commented 3 months ago

Bagnon isn't working when bagbrother is enabled...was able to disable bagbrother and bagnon worked for my bags, but not for my bank.

I just noticed, my Bagnon is not working, was the Blizzard all in one bag option was still on. So yeah, not working for me either, will wait for either a patch or find a different addon that is working.

Cmed1967 commented 3 months ago

Has anyone tried to reach out to the owner, and determine if this ad is going to be maintained going forward? While I am all for separate fixes, this really needs to be maintained or handed off to someone else officially that will so that sources like Curse Forge can be maintained.

On Sat, Aug 3, 2024 at 10:59 AM jamesw71 @.***> wrote:

Bagnon isn't working when bagbrother is enabled...was able to disable bagbrother and bagnon worked for my bags, but not for my bank.

I just noticed, my Bagnon is not working, was the Blizzard all in one bag option was still on. So yeah, not working for me either, will wait for either a patch or find a different addon that is working.

— Reply to this email directly, view it on GitHub https://github.com/Jaliborc/Bagnon/issues/1911#issuecomment-2266881817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFV6FWFOE2D2F7M2IKQVLZPT45RAVCNFSM6AAAAABLPPTFX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWHA4DCOBRG4 . You are receiving this because you commented.Message ID: @.***>

vril14 commented 3 months ago

doesnt work for me either

Knaledge commented 3 months ago

@dkrusky - you may want to consider pairing up with @frozn (profile). They also produced a patch for Bagnon to get it working with TWW 11.0.0 client - and they are also exploring Warband support.

https://github.com/Jaliborc/Bagnon/issues/1909

Tabion64 commented 3 months ago

Has anyone tried to reach out to the owner, and determine if this ad is going to be maintained going forward? While I am all for separate fixes, this really needs to be maintained or handed off to someone else officially that will so that sources like Curse Forge can be maintained. On Sat, Aug 3, 2024 at 10:59 AM jamesw71 @.> wrote: Bagnon isn't working when bagbrother is enabled...was able to disable bagbrother and bagnon worked for my bags, but not for my bank. I just noticed, my Bagnon is not working, was the Blizzard all in one bag option was still on. So yeah, not working for me either, will wait for either a patch or find a different addon that is working. — Reply to this email directly, view it on GitHub <#1911 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFV6FWFOE2D2F7M2IKQVLZPT45RAVCNFSM6AAAAABLPPTFX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWHA4DCOBRG4 . You are receiving this because you commented.Message ID: @.>

The author has posted on his discord that he is currently abroad for work and it will be updated for the expansion release.