James-Yu / LaTeX-Workshop

Boost LaTeX typesetting efficiency with preview, compile, autocomplete, colorize, and more.
MIT License
10.74k stars 535 forks source link

fix link highlighting in \ref and \input for non-word characters #4448

Closed v4hn closed 2 weeks ago

v4hn commented 4 weeks ago

code version 1.26 (2018) added support for custom symbol selection range through DefinitionLink when providing definitions. The feature was missed in the previous discussion.

Making use of the interface we don't get unexpected splits of symbols in words anymore.

Fixes #4446 and #3312 .

Before

Word-chunked Link Decoration

After

Correct Link Decoration

James-Yu commented 4 weeks ago

Thanks for your contribution!

@jlelong I really cannot recall the implementations on symbol definitions. The modifications look good to me at first sight. May you take a look on them? Many thanks!

James-Yu commented 3 weeks ago

@v4hn Thank you for your contribution. May I ask you to add comments to explain the meaning/content of variables and describe the logic for future maintenance?

jlelong commented 3 weeks ago

Thanks for your contribution!

@jlelong I really cannot recall the implementations on symbol definitions. The modifications look good to me at first sight. May you take a look on them? Many thanks!

For sure. I will on Tuesday. I am away from my computer for two days.

v4hn commented 3 weeks ago

May I ask you to add comments to explain the meaning/content of variables and describe the logic for future maintenance?

Done

v4hn commented 2 weeks ago

Gentle ping?