JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.
MIT License
38 stars 5 forks source link

Ds #137

Closed apmcleod closed 4 years ago

apmcleod commented 4 years ago

This removes the data_structures module, replacing it with df_utils, which contains 2 functions:

This moves the read_csv functionality to midi.csv_to_df (and renames the midi module to fileio).

This adds single_track=False and non_overlapping=False args to all fileio.to functions, except for fileio.dfto* (where it is assumed that you can call clean_df first).

This adds tests for all new and changed functionality, and removes now obsolete tests.

I ensured that ACME is still identiacal to ACMEv1.1, with the same seed, and that all tests pass.

apmcleod commented 4 years ago

Also now fixes #64. Tests pass still and acme is still identical. csv clean time dropped from 20 mins -> 10 mins on my machine.