search

JamesTeague / ubiquitous-train

Apache License 2.0
0 stars 0 forks source link

The app should check for Ad Blockers #15

Open JamesTeague opened 6 years ago

JamesTeague commented 6 years ago

The app will not run with ads. However, Ad/Content blockers have the ability to block the login buttons. I noticed this when trying to test issue #1. I had Ghostery enabled and had Site Analytics blocked. Because of this the Google sign in button did not show on the page.

The app should detect this if possible, and maybe show a warning that sign in buttons may be blocked.

JamesTeague commented 6 years ago

As of now this is invalid as Google OAuth is no longer a thing. Will keep open until a verdict is reached on whether to add this or not.

gpwilson commented 6 years ago

I would build ad block detection if a) ad block is causing issues with other core functionality or b) you just "want" to it. 😆