refactor(test): make JSON generation smarter by using structs

JanDeDobbeleer / oh-my-posh

The most customisable and low-latency cross platform/shell prompt renderer

https://ohmyposh.dev

MIT License

17.51k stars 2.4k forks source link

refactor(test): make JSON generation smarter by using structs #5906

Closed vshulcz closed 3 days ago

vshulcz commented 4 days ago

Prerequisites

[x] I have read and understood the contributing guide.
[x] The commit message follows the conventional commits guidelines.
[x] Tests for the changes have been added (for bug fixes / features).
[x] Docs have been added/updated (for bug fixes / features). (Not applicable as this is a test refactor.)

Description

This PR addresses the TODO: // TODO: make this smarter in the test suite of the Brewfather segment. It seems to me better than the previous implementation with manual JSON concatenation and fmt.Sprintf for formatting.

JanDeDobbeleer commented 3 days ago

@all-contributors please add @vshulcz for code

This is pure magic 🪄! @holopin-bot @vshulcz wizard

holopin-bot[bot] commented 3 days ago

Congratulations @vshulcz, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm3oi4smd128510cmdb7hdql74

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

allcontributors[bot] commented 3 days ago

@JanDeDobbeleer

I've put up a pull request to add @vshulcz! :tada: