search

JanDeDobbeleer / oh-my-posh2

A prompt theming engine for Powershell
MIT License
5.19k stars 284 forks source link

[Feature request] option for adding background color for label in Agnoster #291

Closed ReinWD closed 4 years ago

ReinWD commented 4 years ago

image Here's what happend when I installed Windows-terminal. It was resulted by different transparency implementation of PowerShell & Windows Terminal. Maybe adding a background color can improve exprience on Windows Terminal.

Other Agnoster-like skins may also have this issue.

ReinWD commented 4 years ago

Windows Terminal uses "Acrylic" to get a Acrylic-like look and feel. Text color is not affected by this effect(or they will just be blured).

image

oh-my-fish in WSL&fish works just fine in Windows Terminal.

ReinWD commented 4 years ago

Seems that my clients are specially replacing Black color in background with transparent. "Black" color in background is regarded as transparent by Windows Terminal and IntelliJ Terminal.

Wondering how WSL display black background in Windows Terminal, but transparent in IntelliJ Terminal.

So is it possible to display "real Black" background in every client? e.g. #010101?

JanDeDobbeleer commented 4 years ago

I have a new engine in the works that resolves all of this for you. Color management on Windows a few years ago was a real PITA and very basic. Thankfully that's now resolved as terminals have evolved to actual terminals, so we can fix this properly. Stay tuned, I hope to have ported all the available themes somewhere by next week, at that time I consider it ready for a public release.

ReinWD commented 4 years ago

Nice Job!