JanDeDobbeleer / oh-my-posh2

A prompt theming engine for Powershell
MIT License
5.19k stars 284 forks source link

Alert pop-ups with bell sound on Mac OS PowerShell Core #324

Closed KaiWalter closed 4 years ago

KaiWalter commented 4 years ago

I use oh-my-posh for quite some time on Win10 and wanted to have the same experience on MacOS.

After installing and selecting e.g Agnoster theme, on each new prompt an alert with a bell sound appears.

It seems to be caused by this section:

https://github.com/JanDeDobbeleer/oh-my-posh/blob/f584c18dc98054e4a99f97d4e921f89ccf1ff2cd/oh-my-posh.psm1#L37

What is the background of this? Can it be omitted?

KaiWalter commented 4 years ago

I took out

        if ($location.Provider.Name -eq "FileSystem") {
            $prompt += "$([char]27)]9;9;`"$($location.Path)`"$([char]7)"
        }

and had no negative impact so far.

JanDeDobbeleer commented 4 years ago

I you want to fix this, have a look at V3, this has been addressed in there and you can even use it in zsh and bash ;-)

KaiWalter commented 4 years ago

Thanks @JanDeDobbeleer - right, with V3 the effect is gone.