Jannomag / Yaru-Colors

A fork of Ubuntu's Yaru theme - in different colors
GNU General Public License v3.0
510 stars 42 forks source link

Install as flatpak theme #76

Closed johannesjh closed 3 years ago

johannesjh commented 3 years ago

Feature Request: It would be awesome if installing a yaru-colors theme would also install the theme for flatpak apps, in order for these apps to have the same appearance as .deb-packaged apps.

Background/Motivation: I installed the yaru colors theme and I am very happy with the results. Unfortunately, apps installed via flatpak have a different appearance. Judging from this article https://www.linuxuprising.com/2018/05/how-to-get-flatpak-apps-to-use-correct.html, the fix would be to install the theme for flatpak apps.

Jannomag commented 3 years ago

I was thinking about this but didn't have the time to figure out how flatpak works, yet. Snap was hard enough for me...I was sitting there for 3 days without any results until I got help from a other user.

I will leave this issue open, maybe I find time and motivation over Christmas. So, I can't promise anything.

johannesjh commented 3 years ago

thank you very much for your consideration!

tosziro commented 3 years ago

Guys you can force flatpak to use your custom theme by this command sudo flatpak override --filesystem=~/.themes

johannesjh commented 3 years ago

Thank you for the hint! A more secure version of this would probably include a read-only flag, as follows:

sudo flatpak override --filesystem=~/.themes:ro

I gave it a quick try but it does not seem to work for me. ...I probably need to try some more.

@tosziro have you found the command to be effective? Does it require restarts or re-installations for the command to have any effect?

Mek101 commented 3 years ago

Currently, I've personally already submitted Matcha for approval. I can try and package Yaru-Colors, but I'm going to need @Jannomag permission to publish them on flathub

Muqtxdir commented 3 years ago

@Mek101, it would be better for @Jannomag if you link the flathub PR in your comment above there, that way he can have a look at your work

Mek101 commented 3 years ago

Given that Yanu Colors has a total of a wopping 45 possible combinations, I don't operate directly on the manifests, but I use a python script to generate them from a template

Here's the script: https://gitlab.com/Mek101/flatpak-theme-updater

Here's the template: https://gitlab.com/Mek101/flatpak-theme-presets/-/blob/master/Yaru-Colors/templates/manifest.template

If you want to inspect the generated manifests download the script (the development branch has the Yaru-Colors templates as the time of writing), cd into the directory, then run ./theme_update.sh Yaru-Colors -p, to generate each repo in the repos directory

Here's instead the Matcha dark sea manifest: https://github.com/Mek101/flathub/tree/org.gtk.Gtk3theme.Matcha-dark-sea

Mek101 commented 3 years ago

@Mek101, it would be better for @Jannomag if you link the flathub PR in your comment above there, that way he can have a look at your work

I pinged the wrong username, ops :P

Mek101 commented 3 years ago

ping @Jannomag

Jannomag commented 3 years ago

@Mek101 Tha ja for the script. I’m very busy and can’t work on Yaru-Colors at the moment. I‘ll look at it when I have the time for YC again. 21.04 needs updates as well.

I did most of the things at work but my boss decided to give us more work than usual, so I need to find time at home 😩

Mek101 commented 3 years ago

Well, if you're ok with it, I can package and submit the themes myself, then mantain and keep them up to date

Jannomag commented 3 years ago

Sure, you mean just the flatpak, then maintain it when I released updates?

Mek101 commented 3 years ago

Precisely. I will make and submit the manifests for the current version, then update them when you release a new one, and so on

Jannomag commented 3 years ago

This would help a lot, thanks. If you like you can send me the links to the packages so i can add them to the Readme and Gnome-Look Page.

Mek101 commented 3 years ago

The packages are hosted as @flathub repositories. As of now, they don't exist yet. I will ping you as soon as they're all published. (Plus flatpak themes don't require manual installing and don't have a store page; the flatpak command installs them automatically according to the currently set theme)

Muqtxdir commented 3 years ago

Just fetched the runtimes from flathub and I must say absolutely great work @Mek101 for getting this on flathub.org. Really appreciate you doing this :smiley:

Mek101 commented 3 years ago

You welcome :+1:

Mek101 commented 3 years ago

@Jannomag all packaged and published 👍

Jannomag commented 3 years ago

Awesome, thanks (nice birthday present 😂)