search

Jannyboy11 / InvSee-plus-plus

A bukkit plugin for manipulating player inventories
Other
92 stars 18 forks source link

Support for Magma 1.16.5 #43

Closed golfista closed 1 year ago

golfista commented 1 year ago

it doesnt work

Jannyboy11 commented 1 year ago

Okay, I see what is the issue. I will see if I can find a fix this afternoon.

Jannyboy11 commented 1 year ago

It seems that Magma has a remapping bug, as Magma 1.16.5 is discontinued, I would recommend the Mohist server software. I will still see if I can make it work on Magma though.

golfista commented 1 year ago

I see, appreciate you for trying fixing this problem

Jannyboy11 commented 1 year ago

The bug in Magma is that it doesn't remap methods of types in plugin inherited from NMS types. So if I want to make it work on Magma, I would have to reimplement all methods of MainNmsInventory, MainNmsContainer, EnderNmsInventory and EnderNmsContainer, but using their obfuscated SRG-names. This is a lot of effort, so I won't be done with this any time soon. I'm still considering whether I should actually do this at all, since this is really a bug in Magma.

Jannyboy11 commented 1 year ago

Ok, I decided to fix this. New release within an hour. But I think you're still better off using Mohist, since other plugins that utilise NMS are likely to break as well.

Jannyboy11 commented 1 year ago

Should be fixed as of https://github.com/Jannyboy11/InvSee-plus-plus/releases/tag/v0.19.8. If it works for you, can you close the issue please?

golfista commented 1 year ago

Sure, thank you so much.

On Sun, Apr 2, 2023 at 2:07 PM Jan @.***> wrote:

Should be fixed as of https://github.com/Jannyboy11/InvSee-plus-plus/releases/tag/v0.19.8. If it works for you, can you close the issue please?

— Reply to this email directly, view it on GitHub https://github.com/Jannyboy11/InvSee-plus-plus/issues/43#issuecomment-1493405231, or unsubscribe https://github.com/notifications/unsubscribe-auth/APO6B6EX4R6MQF345A4OSSTW7G56HANCNFSM6AAAAAAWQCQ5MI . You are receiving this because you authored the thread.Message ID: @.***>

Jannyboy11 commented 1 year ago

You closed the issue before the plugin's jar files were available o.0, please download them from https://github.com/Jannyboy11/InvSee-plus-plus/releases/v0.19.8.

Jannyboy11 commented 1 year ago

It seemed I didn't push my changes to GitHub yet.. >.< Could you redownload the plugin from that link (should be available in ~30 minutes)?