Janus1992 / KSP_Starship-kOS-Interface

An Interface for automating the 'Starship Expansion Project' and 'Starship Launch Expansion' mods within Kerbal Space Program
GNU General Public License v3.0
15 stars 2 forks source link

Booster smashes into tower in KSRSS 2.5x #12

Closed KnedlikMCPE closed 3 months ago

KnedlikMCPE commented 3 months ago

Pretty self-explanatory... Playing KSRSS 2.5x, and superheavy quite reliably smashes into the OLM tower during the landing burn - it lands roughly 10-20 meters long.

Janus1992 commented 3 months ago

The landing burn is still under adaptation after IFT4, and will be started even later when the next update is out. Nevertheless, it shouldn't do that. What's the final LngError value at the moment of landing burn start? Could you provide a screenshot with the kOS terminal opened at that particular moment?

KnedlikMCPE commented 3 months ago

Got one as the burn was starting and one at the end screenshot7 screenshot8

KnedlikMCPE commented 3 months ago

Seems that the launchpad coords are wrong - I replaced the ending 96 in longitude with 4 and it works now? Just the chopsticks don't want to cooperate

wastedemu commented 3 months ago

On my install, the engine section of the booster always hits the top of the tower. Only happened after the latest update with the IFT-4 profile a few days ago

KnedlikMCPE commented 3 months ago

I'm currently doing some tweaking to make it work. I've managed to tweak the longitude and now working out the mechazilla timing. May send the files if it happens to work.

Janus1992 commented 3 months ago

Interesting! If you enable the showing of Trajectories in-flight, do you see if the LZ is offset from the OLM? Also, could you post the coordinates?

KnedlikMCPE commented 3 months ago

The coordinates are 28.50895 (lat) and -81.203375 (lon) I'm not sure, however currently I'm trying to solve the mechazilla not responding correctly - being generally too slow and not catching the booster.

Janus1992 commented 3 months ago

Thanks. I'll look at it in a few days when I have the time. I also noticed problems with the arms being too slow on occasion. Not sure exactly why this happens, but I'm making some changes in the next updates.

Janus1992 commented 3 months ago

If you find time, could you check if the bug is still there with the latest version? I made some changes and I am looking for some feedback

KnedlikMCPE commented 3 months ago

Will check tomorrow (about ~18h from now at most) and let you know.

KnedlikMCPE commented 3 months ago

The landing zone moved the right amount, but exactly the opposite way

Janus1992 commented 3 months ago

I didn't move the landing zone, just changed the guidance. Got any screenshots again?

KnedlikMCPE commented 3 months ago

screenshot20

Janus1992 commented 3 months ago

Another screenshot at 1500m, and also one at 500m please. This looks weird! Does it slam into the ground?

KnedlikMCPE commented 3 months ago

I'll grab them once home. It lands softly, but tells me it's too far from mechazilla.

Janus1992 commented 3 months ago

Maybe it happens due to the fact it's 2.5x sized. I thought KSRSS is 2.7x? Can you provide a source to your download?

Rescaled 2.5x I haven't gotten around to changing yet. EDIT: Caught on the first try..

What might be useful info:

Go to the booster terminal (anytime), press Ctrl + C and type in this: print ship:body. (always with the dot at the end) print ship:body:name. print ship:body:radius. print rescale.

Screenshot the results

KnedlikMCPE commented 3 months ago

I just round to 2.5x, but it is indeed 2.7x. I just arrived home and I'll see how tired I'll be, so I might either send it today or tomorrow morning.

KnedlikMCPE commented 3 months ago

screenshot21 screenshot22

Janus1992 commented 3 months ago

I'm surprised it still overshoots the tower. Which ship did you launch before? Cargo/Tanker/Depot/Crew? If you get around to it, can you also send a ksp.log in here?

KnedlikMCPE commented 3 months ago

Tanker, haven't tried with the others... I updated by deleting the folder in GameData and then placing the KSP/ folder in KSP root, is that correct?

Janus1992 commented 3 months ago

Probably yes, I describe what it should look like in the readme

Janus1992 commented 3 months ago

Here are some screenshots of mine. Ours are remarkably similar, with one notable exception. Screenshot_20240620_203447 Screenshot_20240620_203457 On mine the landing ratio (and therefore throttle) is 0.98 and on yours it's 1.3 which means it has either started the landing burn later or the vehicle is not slowing down as fast as it should. Are you running any kind of MechJeb throttle smoother or thrust/Q limiter?

Screenshot_20240620_203533

KnedlikMCPE commented 3 months ago

I shouldn't be, MJ is white on all options

Janus1992 commented 3 months ago

Then the only thing I can imagine that is different is the booster mass. Perhaps I made a mistake with Community Resource Pack and its LqdMethane fuel amount? I uploaded a new booster script which should also print the booster mass. Could you use that to make screenshots of right before the landing burn and various points during the landing burn? We could confirm if mass is the issue like this.

EDIT: Maybe also keep the booster cluster menu open so I can see its actual thrust. Also I checked the LqdMethane amount and it fits for the mass it should have..

KnedlikMCPE commented 3 months ago

screenshot24 screenshot25

Janus1992 commented 3 months ago

I don't see any error in the thrust levels. Mass/Thrust are also fine, so it must be something else. You do seem to have options for persistent thrust and things. Can you either:

Let me know if you find out what mod is causing this behaviour, as I may try it out myself and see if I can make a fix for it.

KnedlikMCPE commented 3 months ago

Hmm, seems that removing PersistentThrust fixed it. Thanks for the tip!