Jarrodsz / dokku-edgedb

an edgedb plugin for dokku
MIT License
13 stars 0 forks source link

Enable/disable admin UI and printout the admin URL. #9

Open Jarrodsz opened 1 year ago

Jarrodsz commented 1 year ago

It would be great if one could expose the edgedb admin UI with a command for the plugin.

Since the admin UI can be enabled and disabled the command should probably just enable or disable it and if enabled show the admin UI URL in the console so you can easily bookmark it for usage.

One can then manually set firewall rules to prevent the admin UI to be accessible to the world.

Perhaps, its possible to set the admin URL to a fixed Port so you would not need to change your firewall rules each time. In the case there are multiple edgedb instances on the same dokku server it would be, if possible perhaps be a good idea to increment the port numbers the edgedb UI runs on.

Say a "Wise" default would be port 9000 then edgedb instance #1 would be at port 9000 then edgedb instance #2 would be at port 9001

This way it would be easily managable.

Something like:

dokku edgedb:admin enable dokku edgedb:admin disable

Setting firewall should be probably be managed outside of the plugin, in my case I use DigitalOcean to set firewall rules on my VPS.

IgnisDa commented 1 year ago

Sounds like a good idea. What do you feel about exposing the UI on subdomains instead? That is what we do for my surrealdb plugin (https://github.com/IgnisDa/dokku-surrealdb/wiki/SSL-configuration).

Jarrodsz commented 1 year ago

Subdomain would be even better yes 🙏

IgnisDa commented 1 year ago

Does this look good?

dokku edgedb:expose-admin lollipop dbdomain.dokku.me

This will set up port forwarding, and SSL certificates to the correct port.

Jarrodsz commented 1 year ago

To me it looks great im sure you know best i thrust in your expertise over my noviceness 🙏

Jarrodsz commented 1 year ago

Waiting a bit for the next stable edgebb. May i ask if you managed to get this working already?

An easy way of exposing the edgedb ui safeley would be of tremdendous help in live for debugging and review puroposes.

If not is there anything i can assist to make this feature implemented 🙏?

Jarrodsz commented 10 months ago

Any updates on your edgedb plugin?🙏 With v4 around it would be freat if this could get a update for easy deployments

IgnisDa commented 10 months ago

Nope sorry, I don't use edgedb anymore. If you want, I can transfer this repo to you.

Jarrodsz commented 10 months ago

Could be an idea - I can work on it and get some other typescript edgedb users onboard.

If you do not want to maintain the repro im happy to do so.

Kind regards

IgnisDa commented 10 months ago

Sent you the request.