search

JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
63 stars 9 forks source link

Add F41 tests #145

Closed JasonN3 closed 4 weeks ago

JasonN3 commented 1 month ago

This adds version 41 to the tests and adds the header for the flatpak_remote option. Fixes #144

Summary by CodeRabbit

JasonN3 commented 1 month ago

/run tests

noelmiller commented 1 month ago

/run tests

noelmiller commented 1 month ago

Yeah, using our old workaround works. Not sure the feature works properly in Anaconda yet. I can always check upstream with the Anaconda devs. Thoughts @JasonN3 ?

JasonN3 commented 1 month ago

@coderabbitai review

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request involve modifications to several files related to the Flatpak environment setup and configuration. Key updates include the addition of version "41" in the GitHub Actions workflow, adjustments to the `flatpaks` array, and the removal of the `exclude` section. The `flatpaks/Makefile` now includes a command to install Flatpak if not present. Conditional logic based on Flatpak version is introduced in the `lorax_templates` and `test/iso` scripts. Lastly, an assertion safeguard is added in `test/vm/flatpak_fedora_repo_disabled.yml`. ## Changes | File | Change Summary | |----------------------------------------|---------------------------------------------------------------------------------------------------------| | .github/workflows/build_vars.yml | Added version "41" to `BUILD_MATRIX`, updated `flatpaks` array, removed `exclude` section, updated `include` entry for version "41". | | flatpaks/Makefile | Added command to check for and install Flatpak if not present in `script.sh`. | | lorax_templates/flatpak_set_repo.tmpl | Introduced conditional logic for Flatpak version; added section header for version "41" and updated method calls for lower versions. | | test/iso/flatpak_repo_updated.sh | Added conditional check for `_FLATPAK_REPO_URL` based on `VERSION`; maintained existing logic for repository updates. | | test/vm/flatpak_fedora_repo_disabled.yml | Added `when` clause to assertion task for `flatpak-add-fedora-repos.service` to prevent errors if undefined. | ## Assessment against linked issues | Objective | Addressed | Explanation | |--------------------------------------------------|-----------|------------------------------------------------------| | Ensure `/etc/anaconda/conf.d/anaconda.conf` has a section header for F41 images (#144) | ✅ | | | Prevent Anaconda from crashing during installation due to missing header (#144) | ✅ | |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
JasonN3 commented 4 weeks ago

@coderabbitai review