JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
65 stars 9 forks source link

[FR] Add ability to append automated kickstart to the ISO #48

Closed noelmiller closed 8 months ago

noelmiller commented 9 months ago

Is your feature request related to a problem? Please describe. Not a specific one for me, but it would be cool to add the ability to have common custom kickstart options appended to the kickstart to automate certain aspects of the install.

Describe the solution you'd like See above

Describe alternatives you've considered You could have someone include a kickstart after the fact using xorriso, but it would be nice to include it as part of ISO generation

JasonN3 commented 8 months ago

This isn't really meant to be a replacement of an entire job or workflow. It's just meant to be a step in a job. If they want to add a kickstart file, they can just use mkksiso (https://weldr.io/lorax/mkksiso.html). It's a utility specifically made for adding a kickstart to an ISO and adjusting the grub config to call that kickstart

noelmiller commented 8 months ago

Do we want to add this as a feature to use mkksiso if a kickstart file is provided or just inform users to use the tool after the ISO is created?

I'm open to either if we think adding this as a feature is too much scope creep.

JasonN3 commented 8 months ago

Do we want to add this as a feature to use mkksiso if a kickstart file is provided or just inform users to use the tool after the ISO is created?

I'm open to either if we think adding this as a feature is too much scope creep.

Just tell them to use the tool. There's no need for it to be in this action.