search

JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
63 stars 9 forks source link

[BUG] Cannot run action outside of build-container-installer repo #54

Closed noelmiller closed 8 months ago

noelmiller commented 8 months ago

Describe the bug When using the action, it adds a pr tag to the container. This is useful for testing in the build-container-installer repo, but it breaks the ability to use the action outside of the repo.

This tag should be the PR number only when used by the build-container-installer repo. It should be equal to the action_ref used by the action every other time.

To Reproduce Steps to reproduce the behavior: https://github.com/ublue-os/bluefin/actions/runs/8236695396/job/22523736706

noelmiller commented 8 months ago

This logic in particular needs to be fixed: https://github.com/JasonN3/build-container-installer/blob/bfa150ceebf096e1e23c652a1e437a98ed4f6085/action.yml#L80-L82