search

JasonN3 / build-container-installer

Creates an ISO for installing a container image as an OS
GNU General Public License v3.0
63 stars 9 forks source link

[BUG] Issues with Bootc on Fedora 38 #58

Closed noelmiller closed 8 months ago

noelmiller commented 8 months ago

Describe the bug It is likely to do with the version of bootc packaged for Fedora 38, but the bootc switch command does not work properly for Fedora 38 based containers with Bootc installed in them.

To Reproduce Steps to reproduce the behavior: Bluefin GTS (based on Fedora 38) has this specific issue

Expected behavior Post kickstart script to function properly to switch remote for rpm-ostree

Potential Solutions

  1. Add a check to determine if the command bootc switch --mutate-in-place is available
  2. Check to see if the image is based on Fedora 38 and if it is, fallback to the sed method.
  3. Comment out bootc switch command since the sed method does what bootc switch does anyway.
JasonN3 commented 8 months ago

@noelmiller Can you please test PR #69 to see if that resolves your issue? The bootc command will only be used if it exists and the OS is 39 or higher

noelmiller commented 8 months ago

@noelmiller Can you please test PR #69 to see if that resolves your issue? The bootc command will only be used if it exists and the OS is 39 or higher

Yup, I can do that, give me a bit.

noelmiller commented 8 months ago

Resolved by #69. Go ahead and merge :)