search

Javanaise / mrboom-libretro

Mr.Boom is an 8 player Bomberman clone for RetroArch/Libretro
http://mrboom.mumblecore.org
MIT License
206 stars 61 forks source link

VGA: Fix color expansion (666 to 888) #95

Closed SimpleTease closed 3 years ago

frranck commented 3 years ago

Hello, do you see any difference? What is the reasoning?

frranck commented 3 years ago

Untitled

frranck commented 3 years ago

OK we can see a small difference...

frranck commented 3 years ago

So this is less saturated?

SimpleTease commented 3 years ago

I've seen this "bug" several times in other projects. The concern is that the full color range is not being used. I've met enough who can notice these things.

11111100 = FC (max)
(111111)(11) = FF (max)

10000000 = 80 (mid)
(100000)(10) = 82 (mid)

00000000 = 00 (min)
(000000)(00) = 00 (min)

It's very minor color change but I've dealt with other devs who told me to fix it the proper way. Mednafen author uses linear equations ((0.0f - 63.0f) / 63.0f) * 255.0f, which generates the same bitshift results.

Personally I don't care enough either way, but wanted to bring it up once to discuss.

frranck commented 3 years ago

thanks, nice catch