Jayad / enterprise-log-search-and-archive

Automatically exported from code.google.com/p/enterprise-log-search-and-archive
0 stars 0 forks source link

Problems introduced in r1185 and r1196 #211

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Changes to:
* r1185: Controller.pm - line 794
        if ($user->preferences->{tree}->{default_settings}->{rows_per_page}){

* r1196: Query.pm - line 125
        if ($self->user->preferences->{tree} and

Seem to have caused cron.pl and peer querying problems discussed in these 
threads:
https://groups.google.com/d/topic/enterprise-log-search-and-archive/rWU6ifdfLTg/
discussion
https://groups.google.com/d/topic/enterprise-log-search-and-archive/r4pIjnt2FbA/
discussion

I've changed each of the above lines with the following, which appear to be 
working.
* r1185: Controller.pm - line 794  (added "$user->preferences and " as first if 
condition)
        # if ($user->preferences->{tree}->{default_settings}->{rows_per_page}){
        if ($user->preferences and $user->preferences->{tree}->{default_settings}->{rows_per_page}){

* r1196: Query.pm - line 125 (added "$self->user->preferences and " as first if 
condition)
        # if ($self->user->preferences->{tree} and
        if ($self->user->preferences and $self->user->preferences->{tree} and

The changes are based on observing QueryParser.pm line 154:
if ($self->user->preferences and 
$self->user->preferences->{tree}->{default_settings} and

Original issue reported on code.google.com by kebut...@gmail.com on 24 Apr 2014 at 5:48

GoogleCodeExporter commented 9 years ago
Should be fixed in 1198

Original comment by mchol...@gmail.com on 28 Apr 2014 at 8:25