Jaycar-Electronics / Duinotech-Starter-Kit-For-Arduino

Arduino Start Kit Projects
GNU General Public License v3.0
29 stars 13 forks source link

Traffic light project #3

Open Nutskin opened 4 years ago

Nutskin commented 4 years ago

I noticed at the start of the code it had; int GREEN = 2; int YELLOW = 3; int RED = 4;

When according to the diagram given it should be; int GREEN = 8; int YELLOW = 9; int RED = 10;

Also if you follow the diagram to the T then the lights go red, yellow, green. When it should be the reverse order. You can either swap the LED positions or swap output 8 and 10 the fix this.

Jaycar-Electronics commented 4 years ago

yes sorry about this one, not sure where this came from.

you're 100% correct; changed it here: https://github.com/Jaycar-Electronics/Arduino-Starter-Kit/commit/c1917a06000c23cd67fa22fe89ffc59a3cd7f4c3#diff-214a4da58fccee8c404400918da6d1bd