Jaychristy23 / cgt-calculator-project

0 stars 0 forks source link

Gain/loss seems swapped #1

Open TrevorHansen opened 4 days ago

TrevorHansen commented 4 days ago

Great effort with the calculator!

It seems like in some cases gains and losses are swapped?

image

Jaychristy23 commented 4 days ago

Cheers! Will take a look now.

On 26 Nov 2024, at 11:07 am, Trevor Hansen @.***> wrote:

Great effort with the calculator!

It seems like in some cases gains and losses are swapped?

image.png (view on web) https://github.com/user-attachments/assets/6208a034-2747-4cf8-949e-cb1565a5ab92 — Reply to this email directly, view it on GitHub https://github.com/Jaychristy23/cgt-calculator-project/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/BNGIJLSKSCZFSEU2CO6VDE32CO3VLAVCNFSM6AAAAABSPFQKJGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4TENRWHE4DQNY. You are receiving this because you are subscribed to this thread.

TrevorHansen commented 4 days ago

Yes, It's giving the correct answer now. Can you add a test case for it?

Jaychristy23 commented 4 days ago

tried to do a bit of research, but what’s a test case? youtube isn’t great at explaining things…Sent from my iPhoneOn 26 Nov 2024, at 11:30 AM, Trevor Hansen @.***> wrote: Yes, It's giving the correct answer now. Can you add a test case for it?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>