search

JeCFe / react-design-system

React design system using TypeScript and Storybook
https://react-design-system.jessicafealy.dev/
MIT License
0 stars 0 forks source link

Deploying to unique github pages on PR and main #21

Open JeCFe opened 10 months ago

JeCFe commented 10 months ago

At the moment the code will only deploy both the node package and documentation when a release is triggered. It might be possible to do PR Previews with GitHub pages so I can ensure storybook looks decent before approving the merge, also having github pages for main will allow better visibility of main.

The end goal is 3 GitHub pages and 1 node package

  1. Node package and storybook page to reflect the current release
  2. Main GitHub pages to reflect the current main
  3. PR review GitHub pages to reflect the PR changes

I would want the PR previews to be self-destructive after the PR has been merged ideally. In addition to this, it would provide a benefit to include build steps on the PR to check for linting, any tests, and ability to build. #LetKeepMainPretty

JeCFe commented 10 months ago

As of Nov '23 Github is still developing such a feature https://github.com/orgs/community/discussions/7730#discussioncomment-7603270

JeCFe commented 1 week ago

^ this issue is still on going with no estimate timeline for completion - issue will continue to remain open for the time being