JeanSchoeller / iio-hyprland

Listen iio-sensor-proxy and auto change Hyprland output orientation
GNU General Public License v3.0
47 stars 19 forks source link

fix: rotation of touch and tablet not working #14

Closed short-circuit closed 5 months ago

short-circuit commented 9 months ago

fixes #13

Please let me know if there should be any other changes.

tofeeh commented 8 months ago

Dude, you have a hardcoded solution for your laptop, and it broke iio-hyprland for everyone else. previous solution work, and after this new pull it stops here is from my hyprctl devices

Tablets:
    Tablet at 62d849584670:
        wacom-hid-52cd-pen

Touch:
    Touch Device at 62d8490bb920:
        wacom-hid-52cd-finger

Can you tell me how this should be rotated according to the update you have made? Why don't you use OR and add your device name pattern to the awk list?

short-circuit commented 8 months ago

Hey sorry if this caused you issues. The pull request is still open though, so no merge has been done and it is not available on the master repo. You can still normally use the master branch without using my pull request.

I tried this on multiple convertibles (thinkpad x13, asus x13, asus zenbook flip) with latest hyprland from git and worked on all devices so far.

Can you tell me your hyprland version so I can test it with the specific version and what device that is? Also, if possible, post the output log so I can see what it is doing? I can try changing the implementation based on your input so that it's backwards compatible.

The keyword implementation should rotate all devices that are recognized as touch and tablet. The previous implementation did not work for the devices I use.

Thank you

Mahgozar commented 8 months ago

this worked for me thank you for the fix

tofeeh commented 8 months ago

It was my skill issue. I connected the hyprland update with this commit, I tested it, and it works, thank you, but now I have another issue image the screen rotates, but not all elements rotate. Another issue is that it does not rotate the mouse input. Is there a way to change the orientation of all input devices? (How will the keyboard accept rotation?)

Yusuf-Duran commented 8 months ago

this does not seem to work for me, I still get the same error

./iio-hyprland 
ok
special category's first value must be the key. Key for <device> is <name>
special category's first value must be the key. Key for <device> is <name>
special category's first value must be the key. Key for <device> is <name>
special category's first value must be the key. Key for <device> is <name>

Maybe I set it up wrong but here is the information about my system: Device : Surface Pro 7 Distro: NixOs Hyprland: v0.36.0

Edit: given the mention of hyprctl devices output I also figured might aswell add this here in case it is needed

Tablets:
    Tablet at 2409e70:
        ipts-045e:099f-stylus
    Tablet at 1afc790:
        ipts-stylus

Touch:
    Touch Device at 2382810:
        ipts-045e:099f-touchscreen
    Touch Device at 23ff550:
        ipts-touch
Yusuf-Duran commented 8 months ago

nvm seems to work now (I'n not fully sure what I changed but just ignore my previous comment)

sondresj commented 7 months ago

This actually fixed it for me too, seems like hyprland ignores device config but respects input:touchdevice

jacekpoz commented 6 months ago

works on Dell Latitude 7320 Detachable, nixos

JeanSchoeller commented 5 months ago

Merged.