feature: add `--left-master` and `--right-master` flags

JeanSchoeller / iio-hyprland

Listen iio-sensor-proxy and auto change Hyprland output orientation

GNU General Public License v3.0

47 stars 19 forks source link

feature: add `--left-master` and `--right-master` flags #23

Closed ForgotMyPasswd closed 2 months ago

ForgotMyPasswd commented 5 months ago

Adds a new flag --rotate-master-layout which, when passed in, rotates the master layout on the selected monitor so the master window is on the top when the screen is rotated vertically or on the left when the screen is horizontal. This commit also utilises batch commands as recommended in the hyprland documentation (see #20).

Possible issues:

No error messages are given to the user
This assumes that the user wants the master window to always be on the left side or on top. It will also undo any changes the user makes with a keybinding when the device is rotated again. Maybe a config file can be used?

JeanSchoeller commented 4 months ago

That's a pretty good idea. Do you think instead of the config file working with different flags: [ left / right or bottom / top ] would be sufficient? Merged #20 for the batch commands, my bad for delay.

ForgotMyPasswd commented 3 months ago

That could be an option, with the flags corresponding to the position of the master window. This should be straightforward to do with the orientation config option, which ensures that the changes are reflected on every workspace compared to the dispatchers which only apply to the current workspace.

ForgotMyPasswd commented 2 months ago

Things got busy in real life, but I've edited the command line arguments that can be passed through to provide more options. I believe there's a bug in Hyprland right now where the m[] prop for workspace rules doesn't accept monitor names, only the other attributes, since when I run the program the layouts aren't changed despite working fine on earlier Hyprland versions. I'm still keeping this up in case this gets fixed, if needed then the ID of the monitor could be parsed from the hyprctl monitors command as a workaround.