search

JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.56k stars 4.12k forks source link

onMouseDown and onClick conflict with each other in IE #184

Closed StefanBilliet closed 5 years ago

StefanBilliet commented 9 years ago

Hi

I found a bug in IE 11, when in multi select mode. If you start clicking on items in the multiselect dropdown, eventually more items get added than you selected, unless you select the items fairly slowly. I can replicate the behaviour in the current example page. In Chrome, the issue doesn't present itself.

It's like the onMouseDown and the onClick in buildMenu() conflict with each other in IE, because if I remove onMouseDown, I don't see it happening anymore. Thing is though that if only the onClick is present, the menu closes after selecting an item. If only onMouseDown is present, the menu stays open. https://github.com/StefanBilliet/react-select/commit/45f0f02ea86dbd3db1f0c78f7a1d983947a17b45

dcousens commented 9 years ago

Still the case?

gwyneplaine commented 5 years ago

Have been unable to reproduce this in v2.x Closing this issue, if for some reason you feel that what I've described above doesn't correctly address your problem, please feel free to create a new issue. Mostly doing this for clarity ad to reduce our issues list down to a sane and relevant number of actionable tasks.