search

JedWatson / react-select

The Select Component for React.js
https://react-select.com/
MIT License
27.56k stars 4.12k forks source link

docs(Sortable MultiSelect): replace react-sortable-hoc example by dnd-kit or another #5159

Open saradevh opened 2 years ago

saradevh commented 2 years ago

In docs (Advanced) in Sortable MultiSelect, your advising to use react-sortable-hoc: https://github.com/JedWatson/react-select/blob/fe7dab371290b87c425d9036b66febcf4d1beead/docs/pages/advanced/index.tsx#L51

But it's no longer recommended, from the lib itself: https://github.com/clauderic/react-sortable-hoc#%EF%B8%8F-important-notice-for-new-consumers

They suggest to look on dnd-kit side.

Methuselah96 commented 2 years ago

Thanks for the issue, we should indeed update that example. Feel free to make a pull request if you have time.

saradevh commented 2 years ago

Well noted, I'll see if I have time :)

codercodingthecode commented 2 years ago

Opened a pr for this issue https://github.com/JedWatson/react-select/pull/5212