Bugfix: JFactory::Finish - Githubissues

JeffersonLab / JANA2

Multi-threaded HENP Event Reconstruction

https://jeffersonlab.github.io/JANA2/

Other

6 stars 9 forks source link

Bugfix: JFactory::Finish #377

Closed nathanwbrei closed 1 month ago

nathanwbrei commented 1 month ago

This PR includes several bugfixes:

JFactory::Finish() wasn't getting called
The final JFactory::EndRun() wasn't getting called
JFactory::BeginRun() was getting called spuriously when no run number was set
JParameterManager::SetDefaultParameter() with conflicting defaults had an edge case where they use the wrong default value

This PR adds:

the parameter jana:show_ticker
a warning about conflicting defaults to the parameter summary

This PR includes several refactorings:

Event clearing and finishing logic is now encapsulated on the JEvent itself instead of the JEventPool
JEvents are automatically configured when the constructor is passed a JApplication