Improvements for running over input HDDM files

[sdobbs]

There are a couple things I came across that would make it more convenient when passing a file of thrown events to MCWrapper instead of using one of the generators:

• a blank argument to GENERATOR_CONFIG is not properly handled
• why bother loading beam parameters from RCDB (or otherwise) if they are never used? this is a hassle

[T-Britton]

What do you mean not properly handled? There are a couple of generators that I think don't use the configs....though maybe I fixed that a while ago. Or do you mean if you don't have a config it crashes? If the latter I'll improve the handling for passed in files

Laziness. I can skip that step in the case where you pass in a file AND you don't have TAGONLY or beamphotons backgrounds

[sdobbs]

If you pass an empty string for the generator config in the config file then this gets propagated through, so the shell script has one fewer arguments than it is expecting.

On Tue, May 5, 2020 at 9:15 AM T-Britton notifications@github.com wrote:

What do you mean not properly handled? There are a couple of generators that I think don't use the configs....though maybe I fixed that a while ago. Or do you mean if you don't have a config it crashes? If the latter I'll improve the handling for passed in files

Laziness. I can skip that step in the case where you pass in a file AND you don't have TAGONLY or beamphotons backgrounds

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JeffersonLab/gluex_MCwrapper/issues/28#issuecomment-624047839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJAS2RYRE2PAJYX4ETE3RLRQAGNZANCNFSM4MZRX4NA .

[T-Britton]

Ah! Good catch. Wonder when I introduced this one.....I'll fix it soon

edit: I think this only occurs when you explicitly set the Generator config to the empty string......I will patch it to revert to the default "NA"

[T-Britton]

should be all done on the DEV branch