search

JeffersonLab / qphix

QCD for Intel Xeon Phi and Xeon processors
http://jeffersonlab.github.io/qphix/
Other
13 stars 11 forks source link

QPhix-Library CMakeList testing option #102

Open diptorupd opened 7 years ago

diptorupd commented 7 years ago

Now there are two types of testing - gtests and the old t_* tests for timing and data validation against qdp++.

-Dtesting scopes the gtests, and in the root level CMakeList add_subdirectory(tests) is outside the scope of -Dtesting. But inside "tests" CMakeList everything depends on -Dtesting.

I just removed the if( ${testing} ) around everything inside the CMakeList in "tests" directory. Maybe two option flags are needed?

bjoo commented 7 years ago

Hi Dipto, The idea is that we should be able to turn off testing completely if this is desired, so that the code can build without QDP++. The gtest tests are a later addition. I would ask to not push changes to this yet into devel.

Thanks, B

On September 3, 2017 11:49:46 AM EDT, Diptorup Deb notifications@github.com wrote:

Now there are two types of testing - gtests and the old t_* tests for timing and data validation against qdp++.

-Dtesting scopes the gtests, and in the root level CMakeList add_subdirectory(tests) is outside the scope of -Dtesting. But inside "tests" CMakeList everything depends on -Dtesting.

I just removed the if( ${testing} ) around everything inside the CMakeList in "tests" directory. Maybe two option flags are needed?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_qphix_issues_102&d=DwICaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=SC-qvz5njMoFH6cliT5XZQ&m=NUO41KZHW_CMiNGKk5IGU8RBpE044_55n1NVPhpSZqk&s=9VEk3PeGHSfmFXAFieCsQC5zkuI24fMRzaMRfFyH9EU&e=

-- Bálint Joó, Scientific Computing Group, Jefferson Lab Email: bjoo@jlab.org Tel: +1 757 269 5339 Sent from a mobile device

bjoo commented 7 years ago

A comment on this. If testing is enabled, and the -Dtm_clover=TRUE is not set, then the tests-gtest solver test fails, as a the qdp_pack_full_clover<> function is not found. A workaround is to always enable the -Dtm_clover=TRUE option for CMake. Dipto, are you doing this? (I think maybe you were not yet aware of the Twisted mass options as they are new, perhaps you are not?) A longer term fix would be to comment out the test/building the test if tm_clover is not defined for CMake.

diptorupd commented 7 years ago

On 09/05/2017 10:40 PM, Balint Joo wrote:

A comment on this. If testing is enabled, and the -Dtm_clover=TRUE is not set, then the tests-gtest solver test fails, as a the qdp_pack_full_clover<> function is not found. A workaround is to always enable the -Dtm_clover=TRUE option for CMake. Dipto, are you doing this? (I think maybe you were not yet aware of the Twisted mass options as they are new, perhaps you are not?) A longer term fix would be to comment out the test/building the test if tm_clover is not defined for CMake.

No, I just extracted your "timenoqdp" code and built a small standalone dslash-timer for my work.