Jennica416 / STAT545-hw-nichols-jennica

Stats 545 Homework
0 stars 0 forks source link

Homework 5 is ready to be marked #8

Open Jennica416 opened 6 years ago

Jennica416 commented 6 years ago

My assignment can be found here.

zxkathy commented 6 years ago

Hi, Jennica, this is Kathy who is reviewing your HW5. Here are my comments

ksedivyhaley commented 6 years ago

Factor management (drop & reorder): Yes File I/O (data): Yes (only csv) Visualization design: Yes File I/O (write figure): Yes Organized GitHub: Yes Bonus (more forcats, eg relevel): No Reflection: No

Comments:

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.

diermc commented 6 years ago

Hi @Jennica416,

Sorry for the late peer-review I was away at a conference this past week and just flew in this morning (Vincenzo gave me an extension)

Overall your assignment was solid. Great reflections, here are some more details following the rubric.

Coding style -great, very well commented

Coding strategy -nice breakdown of parts used in your code, easy to follow and understand

Presentation: graphs -visuals in task 2 are clean but you could have been more creative with your figure choice, but it does get the point of increasing with year across still so well done. -task 3 is good, but there are so many styles that would have made the pattern with the continents easier to see, such as using plot type geom_density_2d and ordering the countries for increasing order of life expectancy to make the line increasing or by continent to group their data from ind countries together in a final version. -awesome visualization design figures!

Presentation: tables -excellent! very easy to read. -clearly, extra work was put in to display tables well. -nice formatting!

Achievement, mastery, cleverness, creativity -great explanation of arrange() impacts on ggplot -make sure to leave either two spaces or drop 2 lines after figures to make sure your text doesn't jump to the end of the figure-you could expand to explore saveRDS()/readRDS(), and dput()/dget() -Great visualization design section! -clear explanation of writing figures to files with 2 examples. great!

Ease of access for instructor, compliance with course conventions for submitted work -Nice link to your assignment file in the issue for grading and in the main readme file, plus great description there (even if not in the suggested table format) so they can be easily navigated to.

Awesome work! -Sarah