search

JeremyDunn / homebridge-govee-water-detectors

MIT License
6 stars 0 forks source link

Integration with homebridge-govee? #8

Open bwp91 opened 3 years ago

bwp91 commented 3 years ago

Hi @JeremyDunn

I'm in the process of adding bluetooth capability for my homebridge-govee plugin to control the light strips over bluetooth.

Since the bluetooth is there now... it crossed my mind whether to implement the water detectors into my plugin. I'd obviously be using a lot of your code and of course give you credit (since I don't own one of these devices myself)

So just asking whether or not you'd be happy with this, whether you still have time for your plugin and would like to keep it separate, or willing for the functionality to be 'merged' into my plugin.

Thanks Ben

schwaggy commented 3 years ago

@bwp91 it seems that @JeremyDunn doesn't respond. Not now and not 2 months ago when the auth method changed. Can you simply take over without a response? You appear to be more responsive toward the development and maintenance of these plug-ins and I for one would welcome you adding the water detectors to yours. Thank you!

JeremyDunn commented 3 years ago

The auth method didn't change, but the website changed and the process of obtaining your token is different as @bwp91 mentioned in that issue https://github.com/JeremyDunn/homebridge-govee-water-detectors/issues/4#issuecomment-835300650

Anyway, @bwp91 Feel free to take whatever code you find useful in this plugin to use in your homebridge-govee plugin. I think it makes sense the consolidate this into a single plugin. I personally don't get much value out of showing my water detectors in homebridge. If you use their app, you'll get push notifications almost instantly if a leak is detected - which is better than polling their API repeatedly. Also, as far as I can tell, the battery level values returned from their API are not accurate.

bwp91 commented 3 years ago

Thanks @JeremyDunn.

i'm actually implementing the aws-iot connection at the moment so it would be interesting to see with these water detectors whether a message is received in real time rather than needing to poll!

schwaggy commented 3 years ago

Thanks @JeremyDunn.

i'm actually implementing the aws-iot connection at the moment so it would be interesting to see with these water detectors whether a message is received in real time rather than needing to poll!

I've got 18 of them - happy to test for you!