search

Jericho / ZoomNet

.NET client library for the Zoom.us REST API v2
MIT License
68 stars 48 forks source link

Missing enum value of 'pstn' on CallLogTransferInfoExtensionType #305

Closed joshrogers-pg closed 1 year ago

joshrogers-pg commented 1 year ago

An exception is being thrown when parsing a call log payload:

Exception: There is no value in the CallLogTransferInfoExtensionType enum that corresponds to 'pstn'.

Corresponding JSON block: image

Jericho commented 1 year ago

I'm guessing you get the exception when you invoke CallLogs.GetAsync(myUserId) am I right?

What's interesting is that in the context of retrieving a user's call log, the documentation does not mention an "extension_type" under "forwarded_to" at all. It does mention an "extension_type" under "forwarded_by" and the documented possible values are: user, callQueue, autoReceptionist, commonAreaPhone and sharedLineGroup which explains why the CallLogTransferInfoExtensionType enum in ZoomNet has 5 values: User, CallQueue, AutoReceptionist, CommonAreaPhone and SharedLineGroup.

Regardless of what the documentation says though, you clearly have found another possible value and we definetly need to add it to our enum.

P.S.: thanks for the screenshot, it made it easier for me to understand where the problem is coming from. However, it would be even better if you provided this info in a way that I can copy/paste. This would help me test, verify, reproduce and fix such problems (I totally understand you might want to obfuscate sensitive data such as IDs, phone numbers, email addresses, etc. before pasting).

Jericho commented 1 year ago

:tada: This issue has been resolved in version 0.65.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: