search

Jeroen-G / laravel-photo-gallery

A photo gallery for Laravel
40 stars 32 forks source link

Updates composer.json to accept illuminate 4.1 (so that L4.1.x will accept..) #3

Closed AlexRegenbogen closed 10 years ago

Jeroen-G commented 10 years ago

I did this just before you placed your PR. :-) Does your gallery work after this change? Because according to the upgrade guide of Laravel, Illuminate\Routing\Controllers\Controller; should be changed to Illuminate\Routing\Controller; (in the BaseController)

AlexRegenbogen commented 10 years ago

I'm not yet seeing the changes in your repo.

Before I could not complete the composer update cause it would not clone the repo to my Vendor-folder. Main reason I went ahead and copied the needed parts from the Welpen-repo

I also noticed that I have to move stuff around after I get the package running, cause when I copied the parts needed from the Welpen-repo, that made my code local, and that made it a little harder to update my fork ;-(

Hopefully I get to it before the end of the weekend... until then: small teaser: http://www.relexed.com/photos :-)

Jeroen-G commented 10 years ago

I had trouble testing with L4.1 so I didn't release 1.1 yet. I think I am going to completely revamp the package. So please stay tuned with new PRs until monday! The Welpen-repo you mention is also outdated (and not very nice coded in my opinion). BTW, your photo gallery already looks good!

Jeroen-G commented 10 years ago

Done, see the 1.1 release; https://github.com/Jeroen-G/laravel-photo-gallery/releases/tag/v1.1