Jeryn99 / Regeneration

Minecraft Mod - Adds the concept of Regeneration from the show Doctor who
https://minecraft.curseforge.com/projects/regeneration
GNU Lesser General Public License v3.0
31 stars 19 forks source link

[1.16.5] "Second Rneder" messes up visuals #336

Closed Shibva closed 3 years ago

Shibva commented 3 years ago

idk how to put this but Ive noticed than when I sneak, that a second render of the armor that im wearing appears and after trial an error found that this mod was causing it

this is even present in the lattest release

an image of me having the "double" armor render

image

Shibva commented 3 years ago

if my theory is correct, this model is what the REGEN arm movements do, the issue is that is seems to be rendering the armor still and that a possible fix for this is to have it where the armor only renders when the rest of the skin renders (during the regeneration animation)

Jeryn99 commented 3 years ago

Hey there, Yeah, I got a similar report with Botania https://github.com/Suff99/Regeneration/issues/332

I have yet to work out what is causing this, as it seems to be a recent issue, but I don't think it's anything to do with the arms moving, as that is just changing the rotations of the arms and doesn't create new ones or new instances of any of the models. I think it might be something to do with how I am handling render layers

I'll be investigating this more throughly over the coming days

Shibva commented 3 years ago

thanks, and I also noticed that there is an issue wtih the arms moving when mo' bends in installed in 1.12.2 but im guessing that version is no longer supported

I noticed this armor rendering issue when I used epic battle mod when going between modes

Jeryn99 commented 3 years ago

Anything 1.14 and lower is unsupported

Shibva commented 3 years ago

Referencing post I made on the conflicting mods end, hope that this issue can be resolved https://github.com/Yesssssman/epicfightmod/issues/585

Jeryn99 commented 3 years ago

Something they will have to fix on their end

Shibva commented 3 years ago

well, Is there way for a mod to disable a custom render? im not sure exacaly but their cusom player model renders and the one that regeneration seems to add

Shibva commented 3 years ago

@Suff99 if you can fix this, I do have one possabel suggestion, maybe make the second render not render the armor when the rengeneration animation is not being played

Shibva commented 3 years ago

I say this becasue the issue is primarly because of the second render this mod adds is also rendering its armor, this is present even wtihout epic fight present I belive

Shibva commented 3 years ago

in fact I think this issue was fixxed

Shibva commented 3 years ago

Update: I think I figured out how this issue became resolved, idk but I think it has todo with the Second head Render option being enabled or not

Jeryn99 commented 3 years ago

That configuration option only affects timelords