search

Jessecar96 / SteamBot

Automated bot software for interacting with Steam Trade
http://scrap.tf
MIT License
1.34k stars 910 forks source link

Disallow Overriding a Trade Session and Trade End Detection #9

Closed Philipp15b closed 12 years ago

Philipp15b commented 12 years ago

Currently when the bot is in a trade and another user wants to trade with the bot, the current trade is overriden and the new one is used.

This has also to do with trade end detection as the bot is currently unable to stop polling a timed out or finished trade.

geel9 commented 12 years ago

This is a non-issue due to the fact that Steam doesn't let you trade someone in a trade.

Philipp15b commented 12 years ago

But the bot is still unable to quit a trade and detect if an error happened on the user's side.

geel9 commented 12 years ago

It has a catch clause on the poll() side; if the trade is closed, a NullReferenceException is cast and that closes the trade. It can be done much better.

Philipp15b commented 12 years ago

It does not close the trade, it will be still polled and only the error will be logged.

geel9 commented 12 years ago

Reopened because the trade doesn't actually cancel when there is an issue

Philipp15b commented 12 years ago

6fb22a5 should fix this.