JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

fix: mobile card selection experience #3600

Closed Kneesal closed 3 months ago

Kneesal commented 4 months ago

Description

Issue

mobile card selection experience on journey flow

linear[bot] commented 4 months ago

ENG-637 iphone - card selection on Journey map is buggy

github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready journeys preview Mon Oct 21 13:07:00 NZDT 2024
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (83db571) to head (cfbeddf). Report is 554 commits behind head on main.

Files with missing lines Patch % Lines
...pBlockNode/StepBlockNodeCard/StepBlockNodeCard.tsx 40.00% 3 Missing :warning:
...pBlockNode/StepBlockNodeMenu/StepBlockNodeMenu.tsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3600 +/- ## ========================================== - Coverage 89.35% 89.14% -0.21% ========================================== Files 1145 939 -206 Lines 17945 15788 -2157 Branches 2335 2068 -267 ========================================== - Hits 16034 14074 -1960 + Misses 1669 1509 -160 + Partials 242 205 -37 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-analytics](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `95.88% <ø> (ø)` | | | [apps.api-languages](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-users](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `83.16% <ø> (ø)` | | | [apps.journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `45.71% <0.00%> (-0.14%)` | :arrow_down: | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `80.13% <50.00%> (-0.04%)` | :arrow_down: | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `62.82% <0.00%> (-0.25%)` | :arrow_down: | | [libs.journeys.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `85.54% <0.00%> (-0.16%)` | :arrow_down: | | [libs.nest.common](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.decorators](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.powerBi](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.shared.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `84.93% <100.00%> (+0.32%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready watch preview Mon Oct 21 13:07:24 NZDT 2024
github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
videos-admin ✅ Ready videos-admin preview Mon Oct 21 13:07:39 NZDT 2024
github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Mon Oct 21 13:07:59 NZDT 2024