JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

refactor: get footer elements #3618

Closed csiyang closed 3 months ago

csiyang commented 4 months ago

Description

Remove height in footer when unused

linear[bot] commented 4 months ago

DES-42 M - Card UI if the footer was changed

github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready Visit Preview Tue Oct 15 20:51:52 UTC 2024
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.73%. Comparing base (848a864) to head (f4084bc). Report is 612 commits behind head on main.

Files with missing lines Patch % Lines
.../Card/utils/getFooterElements/getFooterElements.ts 97.67% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3618 +/- ## ========================================== - Coverage 89.32% 87.73% -1.60% ========================================== Files 1144 884 -260 Lines 17856 14714 -3142 Branches 2317 1934 -383 ========================================== - Hits 15950 12909 -3041 + Misses 1663 1610 -53 + Partials 243 195 -48 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-analytics](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `90.39% <ø> (-5.48%)` | :arrow_down: | | [apps.api-languages](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-users](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `45.84% <75.92%> (+0.72%)` | :arrow_up: | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `80.16% <72.22%> (-0.06%)` | :arrow_down: | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `63.06% <ø> (ø)` | | | [libs.journeys.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `85.69% <98.14%> (+0.21%)` | :arrow_up: | | [libs.nest.common](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.decorators](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.powerBi](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.shared.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready Visit Preview Tue Oct 15 20:51:08 UTC 2024
github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready Visit Preview Tue Oct 15 20:53:17 UTC 2024
stage-branch-merger[bot] commented 4 months ago

I see you added the "on stage" label, I'll get this merged to the stage branch!

stage-branch-merger[bot] commented 3 months ago

I see you added the "on stage" label, I'll get this merged to the stage branch!

stage-branch-merger[bot] commented 3 months ago

Merge conflict attempting to merge this into stage. Please fix manually.

stage-branch-merger[bot] commented 3 months ago

Merge conflict attempting to merge this into stage. Please fix manually.

github-actions[bot] commented 3 months ago
Warnings
:warning: :exclamation: Big PR (635 changes)

(change count - 635): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by :no_entry_sign: dangerJS against f4084bc1fd46558f11d00ee84be07f00eea6542a