JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

chore: bq video image fields to cf #3650

Closed mikeallisonJS closed 4 months ago

mikeallisonJS commented 4 months ago

Description

Issue

Video image fields are no longer needed on bq import

Solution

Change importer to create cloudflare images and not require video image fields

linear[bot] commented 4 months ago

ENG-1162 remove bigquery image fields-no-qa

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.87%. Comparing base (6d22d1d) to head (bbb9dba). Report is 702 commits behind head on main.

Files with missing lines Patch % Lines
...kers/bigQuery/importers/videoImages/videoImages.ts 33.33% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3650 +/- ## ========================================== - Coverage 91.96% 91.87% -0.09% ========================================== Files 145 145 Lines 1468 1465 -3 Branches 179 178 -1 ========================================== - Hits 1350 1346 -4 - Misses 90 92 +2 + Partials 28 27 -1 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3650/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3650/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `91.87% <33.33%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stage-branch-merger[bot] commented 4 months ago

I see you added the "on stage" label, I'll get this merged to the stage branch!