JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

chore: remove uniqueness on order for studyquestion #3655

Closed mikeallisonJS closed 3 months ago

mikeallisonJS commented 3 months ago

Description

Issue

Unable to defer uniqueness through prisma, so removing for admin

linear[bot] commented 3 months ago

ENG-1175 remove unique order index on study question-no-qa

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 38.46154% with 24 lines in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (4be86cf) to head (7356fce). Report is 605 commits behind head on main.

Files with missing lines Patch % Lines
...src/schema/video/videoStudyQuestion/updateOrder.ts 4.00% 24 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (4be86cf) and HEAD (7356fce). Click for more details.

HEAD has 30 uploads less than BASE | Flag | BASE (4be86cf) | HEAD (7356fce) | |------|------|------| |apps.journeys-admin|6|0| |apps.journeys|6|0| |libs.journeys.ui|6|0| |apps.watch|6|0| |apps.api-journeys|6|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3655 +/- ## ========================================== - Coverage 89.14% 79.17% -9.97% ========================================== Files 915 134 -781 Lines 15561 1340 -14221 Branches 2038 155 -1883 ========================================== - Hits 13872 1061 -12811 + Misses 1489 254 -1235 + Partials 200 25 -175 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3655/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `79.17% <38.46%> (?)` | | | [apps.journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.journeys.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3655/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.