JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

fix: poll options reorder #3662

Closed Kneesal closed 4 months ago

Kneesal commented 4 months ago

Description

poll options can now be re-ordered

linear[bot] commented 4 months ago

ENG-1063 Poll options cannot be re-ordered

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.22%. Comparing base (848a864) to head (1299eb2). Report is 694 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (848a864) and HEAD (1299eb2). Click for more details.

HEAD has 67 uploads less than BASE | Flag | BASE (848a864) | HEAD (1299eb2) | |------|------|------| |libs.nest.common|6|0| |libs.journeys.ui|6|0| |libs.shared.ui|6|0| |apps.journeys|6|0| |libs.nest.decorators|2|0| |apps.journeys-admin|6|3| |libs.nest.powerBi|4|0| |apps.api-journeys|6|0| |apps.watch|6|0| |apps.api-users|6|0| |apps.api-media|6|0| |apps.api-languages|6|0| |apps.api-analytics|4|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3662 +/- ## ========================================== - Coverage 89.32% 80.22% -9.11% ========================================== Files 1144 638 -506 Lines 17856 9972 -7884 Branches 2317 1301 -1016 ========================================== - Hits 15950 8000 -7950 - Misses 1663 1818 +155 + Partials 243 154 -89 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-analytics](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-languages](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-users](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.journeys-admin](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `80.22% <ø> (ø)` | | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.journeys.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.common](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.decorators](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.nest.powerBi](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [libs.shared.ui](https://app.codecov.io/gh/JesusFilm/core/pull/3662/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready Visit Preview Tue Oct 15 22:54:08 UTC 2024