search

JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

fix: email notifications being submitted #3675

Closed Kneesal closed 4 months ago

Kneesal commented 4 months ago

Description

Issue

journey notifications aren't being sent

Solution

prisma to search the userId col for user as opposed to id col

linear[bot] commented 4 months ago

ENG-1183 Investigate missing submitted text in analytics and email notifications

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.16%. Comparing base (1751d15) to head (5f2c932). Report is 680 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (1751d15) and HEAD (5f2c932). Click for more details.

HEAD has 6 uploads less than BASE | Flag | BASE (1751d15) | HEAD (5f2c932) | |------|------|------| |apps.api-media|6|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3675 +/- ## ========================================== - Coverage 91.84% 83.16% -8.68% ========================================== Files 145 22 -123 Lines 1471 196 -1275 Branches 179 24 -155 ========================================== - Hits 1351 163 -1188 + Misses 93 28 -65 + Partials 27 5 -22 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3675/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | | [apps.api-users](https://app.codecov.io/gh/JesusFilm/core/pull/3675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `83.16% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stage-branch-merger[bot] commented 4 months ago

I see you added the "on stage" label, I'll get this merged to the stage branch!