JesusFilm / core

JFP DS Engineering Monorepo
https://docs.core.jesusfilm.org/
19 stars 12 forks source link

fix: really fix studyQuestion sort order #3728

Closed mikeallisonJS closed 3 months ago

mikeallisonJS commented 4 months ago

Description

Issue

StudyQuestion sort order didn't quite work right.

Solution

Simplify, but have a few extra db calls

linear[bot] commented 4 months ago

ENG-1214 really fix studyQuestions sort order-no-qa

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (b9a43fd) to head (46421e2). Report is 651 commits behind head on main.

Files with missing lines Patch % Lines
...src/schema/video/videoStudyQuestion/updateOrder.ts 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3728 +/- ## =========================================== + Coverage 63.06% 91.82% +28.76% =========================================== Files 127 145 +18 Lines 1278 1481 +203 Branches 132 180 +48 =========================================== + Hits 806 1360 +554 + Misses 434 94 -340 + Partials 38 27 -11 ``` | [Flag](https://app.codecov.io/gh/JesusFilm/core/pull/3728/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | Coverage Δ | | |---|---|---| | [apps.api-media](https://app.codecov.io/gh/JesusFilm/core/pull/3728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `91.82% <90.90%> (?)` | | | [apps.watch](https://app.codecov.io/gh/JesusFilm/core/pull/3728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JesusFilm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.